On 2015년 07월 30일 06:14, Dan Carpenter wrote:
On Wed, Jul 29, 2015 at 01:54:54PM -0700, Greg KH wrote:
On Tue, Jul 28, 2015 at 05:47:28PM +0900, Tony Cho wrote:
/**
* Disable power sequencer
**/
- if (!sdio_read_reg(WILC_MISC, ®)) {
+ if(!sdio_read_reg(WILC_MISC, ®)) {
I noticed this style change during my review, but I didn't comment
because I was feeling in a happy mood and because it got fixed again in
patch 13. Normally, of course we don't allow people to break and then
fix things in later patches but this was a white space issue.
It's sometimes hard to know how strict to be. I knowingly allowed far
worse things in that series of 150 unisys patches which was probably
a mistake in retrospect.
regards,
dan carpenter
Yes, I agree with you. It's obviously my mistake while rewriting the codes and found out my mistake so fixed in the
later patch. I will take more care.
Thanks for your advice,
Tony.
--
Cho, Tony
Manager, Staff Engineer | Connectivity System Software Team | Atmel Korea (Wireless solutions BU)
#409, Kins Tower, Jeongja-Dong, Bundang-Gu, Seongnam-Si, Gyeonggi-Do, 463-782, Korea
Phone:82 31 784 8400(Ext. 317); Mobile: 82 10 7232 1523
email: tony.cho@xxxxxxxxx
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
