On 2015년 07월 30일 06:01, Greg KH wrote:
On Tue, Jul 28, 2015 at 05:47:40PM +0900, Tony Cho wrote:
The TODO list is updated for the WILC1000 kernel driver. The TODO list
contains many items listed in time sequence.
I don't understand what you mean by "in time sequence"
Sorry for unclear sentence. This means I will work them step by step in chronological order.
Signed-off-by: Tony Cho <tony.cho@xxxxxxxxx>
Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
drivers/staging/wilc1000/TODO | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/TODO b/drivers/staging/wilc1000/TODO
index 95199d8..6b745cd 100644
--- a/drivers/staging/wilc1000/TODO
+++ b/drivers/staging/wilc1000/TODO
@@ -1,14 +1,15 @@
TODO:
-- remove the defined feature as kernel versions
-- remove OS wrapper functions
-- remove custom debug and tracing functions
+- remove most of warnings reported by checkpatch.pl
"most"? Why not all?
I will end up to remove all of warnings (I must make it) but I need to do them step by step. Most warnings are
from both camelcase and line over 80 characters. They will be removed after most warnings are removed to avoid
confusing new driver coming soon. Again, I will remove all of warnings.
+- remove OS wrapper functions to use kernel API as is
Why reword this, the original line is just fine.
Good point, I agree with you.
- rework comments and function headers(also coding style)
- replace all semaphores with mutexes or completions
-- make spi and sdio components coexist in one build
Why remove this item? It's not done and needs to be done.
The first two lines are still in my TODO list. Do you mean coexistence of spi and sdio? If yes, I will recheck
the driver to find out good solution as you recommend.
+- remove compile warnings related to 64 bit machine
That's a given, I'm not enabling the build of the driver until that
happens. Please work on that next, coding style fixes can happen after
that. As of right now, this driver is marked BROKEN.
thanks,
greg k-h
As you mentioned, I believe it's very important to break down BROKEN status. I will soon send the 64 bit patches
to remove compile warnings while fixing coding styles at the same time. As you know, there are the structural issues
to resolve them in the driver, for example, redundant casting which causes build warnings and the codes are not
readable. However, I will cut down all of them.
Thanks,
Tony.
--
Cho, Tony
Manager, Staff Engineer | Connectivity System Software Team | Atmel Korea (Wireless solutions BU)
#409, Kins Tower, Jeongja-Dong, Bundang-Gu, Seongnam-Si, Gyeonggi-Do, 463-782, Korea
Phone:82 31 784 8400(Ext. 317); Mobile: 82 10 7232 1523
email: tony.cho@xxxxxxxxx
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
