Re: [PATCH] staging: lustre: fixed symbols not being declared static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jul 19, 2015 at 01:46:29PM +0300, Buţiu Alexandru Octavian wrote:
> Fixed sparse warning symbol lnet_upcall and lnet_debug_log_upcall not being
> declared static.
> 
> Signed-off-by: Buţiu Alexandru Octavian <predator5047@xxxxxxxxx>
> ---
>  drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c
> index 4545d54..fd5d798 100644
> --- a/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c
> +++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c
> @@ -61,8 +61,9 @@
>  
>  #include <linux/kallsyms.h>
>  
> -char lnet_upcall[1024] = "/usr/lib/lustre/lnet_upcall";
> -char lnet_debug_log_upcall[1024] = "/usr/lib/lustre/lnet_debug_log_upcall";
> +static char lnet_upcall[1024] = "/usr/lib/lustre/lnet_upcall";
> +static char
> +lnet_debug_log_upcall[1024] = "/usr/lib/lustre/lnet_debug_log_upcall";
>  

I'm pretty sure this breaks the build since this is used in module.c.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux