[PATCH 000/102] staging: rtl8192e: Function names cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This somewhat large series cleans up most of non-static functions 
in rtl8192e driver.

Naming convention similar to other rtlwifi cards was used:
- non-static functions are prefixed with rtl92e_
- static functions will be prefixed with _rtl92e_ (not ready yet - 
  will be posted as separate series)

Apart from standardizing, each function was inspected and some names 
were changed to:
- make naming coherent in driver (ex. use irq not interrupt, irq, Interrupt)
- make name shorter
- reflect function body better

Most of the patches do just name swap, with possible exceptions:
- Function may be re-indented (i.e. arguments are moved around)
- Some extra whitespaces in changed line are removed
etc.

This series may cause several new LONG_LINE warnings - I tried to avoid 
them but prefer readability over strict sticking to 80-line limit.
The following patches cause LONG_LINE warnings:
33, 34, 40, 43 (x5), 44 (x14), 49, 50 (x8), 51 (x7),
56 (x1), 73 (x2), 74 (x9), 78 (x5), 86 (x2), 93

Every patch in series was compile-tested.
Several were also target-tested (nontrivial ones mostly).
Full target-test was performed on final patch in series as well.

Series should apply cleanly to current staging-next/staging-test (b8d1f261).

Mateusz Kulikowski (102):
  staging: rtl8192e: Rename PHY_RF8256_Config
  staging: rtl8192e: Rename PHY_SetRF8256Bandwidth
  staging: rtl8192e: Rename PHY_SetRF8256CCKTxPower
  staging: rtl8192e: Rename PHY_SetRF8256OFDMTxPower
  staging: rtl8192e: Rename cmpk_message_handle_tx
  staging: rtl8192e: Rename rtl8192_adapter_start
  staging: rtl8192e: Rename rtl8192_AllowAllDestAddr
  staging: rtl8192e: Rename rtl8192_ClearInterrupt
  staging: rtl8192e: Rename rtl8192_DisableInterrupt
  staging: rtl8192e: Rename rtl8192_EnableInterrupt
  staging: rtl8192e: Rename rtl8192_enable_rx
  staging: rtl8192e: Rename rtl8192_enable_tx
  staging: rtl8192e: Rename rtl8192e_SetHwReg
  staging: rtl8192e: Rename rtl8192e_start_beacon
  staging: rtl8192e: Rename rtl8192_get_eeprom_size
  staging: rtl8192e: Rename rtl8192_GetHalfNmodeSupportByAPs
  staging: rtl8192e: Rename rtl8192_GetNmodeSupportBySecCfg
  staging: rtl8192e: Rename rtl8192_HalRxCheckStuck
  staging: rtl8192e: Rename rtl8192_halt_adapter
  staging: rtl8192e: Rename rtl8192_HalTxCheckStuck
  staging: rtl8192e: Rename rtl8192_InitializeVariables
  staging: rtl8192e: Rename rtl8192_interrupt_recognized
  staging: rtl8192e: Rename rtl8192_link_change
  staging: rtl8192e: Rename rtl8192_rx_query_status_desc
  staging: rtl8192e: Rename rtl8192_tx_fill_cmd_desc
  staging: rtl8192e: Rename rtl8192_tx_fill_desc
  staging: rtl8192e: Rename rtl8192_update_ratr_table
  staging: rtl8192e: Rename firmware_init_param
  staging: rtl8192e: Rename InitialGain819xPci
  staging: rtl8192e: Rename PHY_ScanOperationBackup8192
  staging: rtl8192e: Rename PHY_SetRtl8192eRfOff
  staging: rtl8192e: Rename rtl8192_BBConfig
  staging: rtl8192e: Rename rtl8192_phy_checkBBAndRF
  staging: rtl8192e: Rename rtl8192_phy_CheckIsLegalRFPath
  staging: rtl8192e: Rename rtl8192_phy_configmac
  staging: rtl8192e: Rename rtl8192_phy_ConfigRFWithHeaderFile
  staging: rtl8192e: Rename rtl8192_phy_getTxPower
  staging: rtl8192e: Rename rtl8192_phy_QueryRFReg
  staging: rtl8192e: Rename rtl8192_phy_RFConfig
  staging: rtl8192e: Rename rtl8192_phy_SetRFReg
  staging: rtl8192e: Rename rtl8192_phy_setTxPower
  staging: rtl8192e: Rename rtl8192_phy_SwChnl
  staging: rtl8192e: Rename rtl8192_QueryBBReg
  staging: rtl8192e: Rename rtl8192_setBBreg
  staging: rtl8192e: Rename rtl8192_SetBWMode
  staging: rtl8192e: Rename SetRFPowerState
  staging: rtl8192e: Rename CamResetAllEntry
  staging: rtl8192e: Rename CamRestoreAllEntry
  staging: rtl8192e: Rename EnableHWSecurityConfig8192
  staging: rtl8192e: Rename setKey
  staging: rtl8192e: Rename set_swcam
  staging: rtl8192e: Rename check_rfctrl_gpio_timer
  staging: rtl8192e: Rename MgntActSet_RF_State
  staging: rtl8192e: Rename NicIFDisableNIC
  staging: rtl8192e: Rename NicIFEnableNIC
  staging: rtl8192e: Rename read_nic_byte
  staging: rtl8192e: Rename read_nic_dword
  staging: rtl8192e: Rename read_nic_word
  staging: rtl8192e: Rename rtl8192_commit
  staging: rtl8192e: Rename rtl8192_config_rate
  staging: rtl8192e: Rename rtl8192_irq_disable
  staging: rtl8192e: Rename rtl8192_irq_enable
  staging: rtl8192e: Rename rtl8192_pci_resetdescring
  staging: rtl8192e: Rename rtl8192_record_rxdesc_forlateruse
  staging: rtl8192e: Rename rtl8192_rx_enable
  staging: rtl8192e: Rename rtl8192_SetWirelessMode
  staging: rtl8192e: Rename rtl8192_tx_enable
  staging: rtl8192e: Rename rtl819x_evm_dbtopercentage
  staging: rtl8192e: Rename rtl819x_query_rxpwrpercentage
  staging: rtl8192e: Rename rtl819x_translate_todbm
  staging: rtl8192e: Rename rtl819x_UpdateRxPktTimeStamp
  staging: rtl8192e: Rename rtl819x_update_rxsignalstatistics8190pci
  staging: rtl8192e: Rename write_nic_byte
  staging: rtl8192e: Rename write_nic_dword
  staging: rtl8192e: Rename write_nic_word
  staging: rtl8192e: Rename deinit_hal_dm
  staging: rtl8192e: Rename dm_backup_dynamic_mechanism_state
  staging: rtl8192e: Rename dm_cck_txpower_adjust
  staging: rtl8192e: Rename dm_init_edca_turbo
  staging: rtl8192e: Rename dm_initialize_txpower_tracking
  staging: rtl8192e: Rename dm_restore_dynamic_mechanism_state
  staging: rtl8192e: Rename dm_rf_pathcheck_workitemcallback
  staging: rtl8192e: Rename dm_txpower_trackingcallback
  staging: rtl8192e: Rename hal_dm_watchdog
  staging: rtl8192e: Rename init_rate_adaptive
  staging: rtl8192e: Rename eprom_read
  staging: rtl8192e: Rename rtl8192_pci_findadapter
  staging: rtl8192e: Rename rtl8192E_resume
  staging: rtl8192e: Rename rtl8192E_suspend
  staging: rtl8192e: Rename IPSEnter
  staging: rtl8192e: Rename IPSLeave
  staging: rtl8192e: Rename IPSLeave_wq
  staging: rtl8192e: Rename LeisurePSEnter
  staging: rtl8192e: Rename LeisurePSLeave
  staging: rtl8192e: Rename rtl8192_hw_sleep_wq
  staging: rtl8192e: Rename rtl8192_hw_to_sleep
  staging: rtl8192e: Rename rtl8192_hw_wakeup
  staging: rtl8192e: Rename rtl8192_hw_wakeup_wq
  staging: rtl8192e: Rename rtllib_ips_leave
  staging: rtl8192e: Rename rtllib_ips_leave_wq
  staging: rtl8192e: Rename init_firmware
  staging: rtl8192e: Rename init_hal_dm

 drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 106 ++---
 drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.h |  10 +-
 drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c  |  11 +-
 drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.h  |   5 +-
 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c     | 396 +++++++++---------
 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h     |  57 ++-
 .../staging/rtl8192e/rtl8192e/r8192E_firmware.c    |  20 +-
 .../staging/rtl8192e/rtl8192e/r8192E_firmware.h    |   4 +-
 drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c     | 438 ++++++++++----------
 drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h     |  66 ++-
 drivers/staging/rtl8192e/rtl8192e/rtl_cam.c        | 117 +++---
 drivers/staging/rtl8192e/rtl8192e/rtl_cam.h        |  16 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c       | 279 +++++++------
 drivers/staging/rtl8192e/rtl8192e/rtl_core.h       |  60 ++-
 drivers/staging/rtl8192e/rtl8192e/rtl_dm.c         | 459 ++++++++++-----------
 drivers/staging/rtl8192e/rtl8192e/rtl_dm.h         |  22 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_eeprom.c     |  40 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_eeprom.h     |   2 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_pci.c        |   2 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_pci.h        |   2 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_pm.c         |  24 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_pm.h         |   4 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_ps.c         |  52 +--
 drivers/staging/rtl8192e/rtl8192e/rtl_ps.h         |  18 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c         |  57 +--
 25 files changed, 1123 insertions(+), 1144 deletions(-)

-- 
1.8.4.1

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux