On Fri, Jul 17, 2015 at 02:47:55PM +0300, Dan Carpenter wrote: > On Fri, Jul 17, 2015 at 04:55:12PM +0530, Sudip Mukherjee wrote: > > On Fri, Jul 17, 2015 at 02:03:48PM +0300, Dan Carpenter wrote: > > > On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote: > > > > By checking for the success of kzalloc we were able to remove the goto > > > > label thus making the code more readable. > > > > > > > > > > No... You've just changed error handling to success handling and added > > > some new indent levels and made a tangled spaghetti exit path even more > > > tangled. Spoderman wants to know, "Why u do dis?" > > I had to go for google to lookup Spoderman or Spiderman. :) > > At the end of the series, isn't the code better looking and simpler > > than the original code? > > Yes, but that's not a very high bar to clear. > > What I'm trying to explain is the beauty of writing one statement after > the other without indenting. understood. I was planning another series for that file so i will include one for this also. But before that I am going to send in the patch for sm7xxfb to move out of staging. Please check that. regards sudip _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
