On Fri, Jul 17, 2015 at 02:03:48PM +0300, Dan Carpenter wrote: > On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote: > > By checking for the success of kzalloc we were able to remove the goto > > label thus making the code more readable. > > > > No... You've just changed error handling to success handling and added > some new indent levels and made a tangled spaghetti exit path even more > tangled. Spoderman wants to know, "Why u do dis?" I had to go for google to lookup Spoderman or Spiderman. :) At the end of the series, isn't the code better looking and simpler than the original code? regards sudip _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
