On Tue, Jun 30, 2015 at 05:34:36PM +0900, Dean Lee wrote: > change type to pointer. that describes _what_ you did, which is obvious from the patch, but not _why_ you did it. You need to describe this much better before I can take it. One comment on the code: > Signed-off-by: Dean Lee <dean.lee@xxxxxxxxx> > --- > drivers/staging/wilc1000/host_interface.c | 22 +++++++++------------- > drivers/staging/wilc1000/host_interface.h | 4 ++-- > 2 files changed, 11 insertions(+), 15 deletions(-) > > diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c > index 1d59f41..1e40dca 100644 > --- a/drivers/staging/wilc1000/host_interface.c > +++ b/drivers/staging/wilc1000/host_interface.c > @@ -640,26 +640,24 @@ static s32 Handle_SetChannel(void *drvHandler, tstrHostIFSetChan *pstrHostIFSetC > * @date > * @version 1.0 > */ > -static s32 Handle_SetWfiDrvHandler(tstrHostIfSetDrvHandler *pstrHostIfSetDrvHandler) > +static s32 Handle_SetWfiDrvHandler(void *drvHandler, tstrHostIfSetDrvHandler *pstrHostIfSetDrvHandler) A void pointer? No, you have full control over your driver, and the structures involved, use a pointer to the real structure, and don't use CamelCase variables for new variables, as you will have to go back and change it again in the future. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
