Re: [PATCH 4/6] staging: wilc1000: rework address value.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -	if ((pstrHostIfSetDrvHandler->u32Address) == (u32)NULL) {
> +	if (pstrHostIfSetDrvHandler->pAddress == NULL) {

In the linux kernel we do not like using 'p' to stand for pointer.  This
new name uses CamelCase.  Use scripts/checkpatch.pl to find obvious
mistakes like this.

The name "address" is too generic.  Use a meaningful name.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux