Re: [PATCH 2/2] staging: rtl8723au: include/rtl8723a_hal.h: use __leXX types in fw header struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> writes:
> On Mon, Jun 15, 2015 at 11:30:41AM +0200, Daniele Alessandrelli wrote:
>> On June 15, 2015 7:47:41 AM GMT+02:00, Sudip Mukherjee
>> <sudipm.mukherjee@xxxxxxxxx> wrote:
>> >On Sun, Jun 14, 2015 at 11:26:35PM +0200, Daniele Alessandrelli wrote:
>>
>> >> - u16 Signature; /* 92C0: test chip; 92C, 88C0: test chip; 88C1:
>> >> MP
>> >A-cut; 92C1: MP A-cut */
>> >> +	__le16		Signature;  /* 92C0: test chip; 92C, 88C0: test chip;
>> >> +				     * 88C1: MP A-cut; 92C1: MP A-cut */
>> >you have also reformatted the comment line here and also that is not
>> >the
>> >multi line comment style.
>> >
>> >regards
>> >sudip
>> 
>> Hi Sudip,
>> 
>> Thank you for your feedback. I have just one question before
>> resubmitting: I guess this code will be eventually moved to
>> drivers/net/wireless so I should use the comment style specific for
>> drivers/net, am I right?
> Hi Daniele,
> I am not aware if drivers/net subsystem has any specific comment style.
> I always knew style should be according to the Documentation/CodingStyle.

Network devices have a recommended style, but it still comes back to the
maintainer of a driver. I prefer the traditional kernel comment style,
so please use that for rtl8723au.

Thanks,
Jes
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux