On June 15, 2015 7:47:41 AM GMT+02:00, Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> wrote:
>On Sun, Jun 14, 2015 at 11:26:35PM +0200, Daniele Alessandrelli wrote:
>> This patch makes field in struct rt_8723a_firmware_hdr use
>endianness-aware
>> types (__leXX), thus fixing the following sparse warnings:
>>
><snip>
>>
>> Signed-off-by: Daniele Alessandrelli
><daniele.alessandrelli@xxxxxxxxx>
>> ---
>> drivers/staging/rtl8723au/include/rtl8723a_hal.h | 17
>+++++++++--------
>> 1 file changed, 9 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723au/include/rtl8723a_hal.h
>b/drivers/staging/rtl8723au/include/rtl8723a_hal.h
>> index d40e420..743b52a 100644
>> --- a/drivers/staging/rtl8723au/include/rtl8723a_hal.h
>> +++ b/drivers/staging/rtl8723au/include/rtl8723a_hal.h
>> @@ -80,10 +80,11 @@ struct rt_8723a_firmware_hdr {
>> /* 8-byte alinment required */
>>
>> /* LONG WORD 0 ---- */
>> - u16 Signature; /* 92C0: test chip; 92C, 88C0: test chip; 88C1: MP
>A-cut; 92C1: MP A-cut */
>> + __le16 Signature; /* 92C0: test chip; 92C, 88C0: test chip;
>> + * 88C1: MP A-cut; 92C1: MP A-cut */
>you have also reformatted the comment line here and also that is not
>the
>multi line comment style.
>
>regards
>sudip
Hi Sudip,
Thank you for your feedback. I have just one question before resubmitting: I guess this code will be eventually moved to drivers/net/wireless so I should use the comment style specific for drivers/net, am I right?
Regards,
Daniele
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
