On Thu, Jun 11, 2015 at 09:15:13AM -0700, Greg Kroah-Hartman wrote: > On Thu, Jun 11, 2015 at 02:22:33PM +0000, Ravindran, Madhusudhanan (M.) wrote: > > From: Madhusudhanan Ravindran <mravindr@xxxxxxxxxxx> > > > > pass wlan irq gpio number in run time using DT as > > mentioned in the TODO list. > > > > Signed-off-by: Madhusudhanan Ravindran <mravindr@xxxxxxxxxxx> > > -- > > * did not test this code on real hardware. > > I need this tested before I can accept something like this, sorry. > > You have to modify the DT file before this can work properly. Yes, I may not have chance to test so I will drop this. > > Also, one complaint: > > > +unsigned int gpio_num = 0; > > That's a _VERY_ generic global variable name you just created, please > don't do that. I think I should have put them in an existing structure with reasonable name, I will make sure that next time. > > thanks, > Thanks for your review. Madhu. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
