Re: [PATCH] staging: wilc1000: pass gpio irq number using DT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 11, 2015 at 02:22:33PM +0000, Ravindran, Madhusudhanan (M.) wrote:
> From: Madhusudhanan Ravindran <mravindr@xxxxxxxxxxx>
> 
> pass wlan irq gpio number in run time using DT as
> mentioned in the TODO list.
> 
> Signed-off-by: Madhusudhanan Ravindran <mravindr@xxxxxxxxxxx>
> --
> 	* did not test this code on real hardware.

I need this tested before I can accept something like this, sorry.

You have to modify the DT file before this can work properly.

Also, one complaint:

> +unsigned int gpio_num = 0;

That's a _VERY_ generic global variable name you just created, please
don't do that.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux