Re: [PATCH] staging: me_daq: use schedule_timeout_interruptible()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 29, 2015 at 06:47:28PM +0200, Nicholas Mc Guire wrote:
> On Fri, 29 May 2015, Ian Abbott wrote:
> 
> > On 29/05/15 16:58, Nicholas Mc Guire wrote:
> >> API consolidation with coccinelle found:
> >> ./drivers/staging/comedi/drivers/me_daq.c:177:1-17:
> >>          consolidation with schedule_timeout_*() recommended
> >>
> >> This is a 1:1 conversion of the current calls to an available helper
> >> only - so only an API consolidation to improve readability.
> >>
> >> Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
> >> CONFIG_COMEDI=y, CONFIG_COMEDI_PCI_DRIVERS=y CONFIG_COMEDI_ME_DAQ=m
> >>
> >> Patch is against 4.1-rc5 (localversion-next is -next-20150529)
> >
> > Minor niggle: you don't really need to say what version the patch is  
> > against in the commit message, as the version will have changed by the  
> > time the patch is committed.  It can be mentioned after the "---" marker  
> > line if relevant, as the stuff after the "---" line does not end up in  
> > the commit message.
> >
> makes sense - will move that down for the other cleanups.

Please fix up and resend so I don't have to hand-edit the patch.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux