On Fri, May 29, 2015 at 05:31:16PM +0200, Nicholas Mc Guire wrote: > API consolidation with coccinelle found: > ./drivers/staging/unisys/visorbus/periodic_work.c:196:3-19: > consolidation with schedule_timeout_*() recommended > > This is a 1:1 conversion with respect to schedule_timeout() to the > schedule_timeout_interruptible() helper only - so only an API > consolidation to improve readability. The hard coded timeout of 10 > jiffies is HZ dependent which it should not be, so it is converted > with msecs_to_jiffies. > > Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y, > CONFIG_UNISYSSPAR=y, CONFIG_UNISYS_VISORBUS=m > > Patch is against 4.1-rc5 (localversion-next is -next-20150529) > > Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx> > --- > > As the actually intended timeout is not documented and msecs_to_jiffies > timeouts can be a factor 10 different from the current effective timeout > this needs to be checked by someone who knows the details of this driver > in any case it should be passed in a HZ independent manner. I need an ack from the maintainers before I can take this. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
