On Fri, May 29, 2015 at 01:52:28PM +0300, Dan Carpenter wrote: > On Fri, May 29, 2015 at 10:06:48AM +0000, Gujulan Elango, Hari Prasath (H.) wrote: > > On Fri, May 29, 2015 at 11:54:09AM +0300, Dan Carpenter wrote: > > > On Fri, May 29, 2015 at 07:44:11AM +0000, Gujulan Elango, Hari Prasath (H.) wrote: > > > > check return value of kzalloc and return error if it fails. > > > > > > > > > > There is a problem with your patch. See if you can spot it. Also can > > > you add to the changelog what are the user visible effects of not > > > checking for kzalloc() failure? Last time with ->flipbuf there were no > > > user visible effects. > > > > > > Also return -ENOMEM seems like the wrong thing. Shouldn't we do some > > > error handling. Also you are not working on linux-next? Some of this > > > stuff is done correctly in linux-next. > > > > > > regards, > > > dan carpenter > > > > > > > Dan,I am working on the staging-testing git tree.I was not aware that > > someone has submitted a similar patch which was reviewed by you & > > sudip.If a patch to address this has already gone in,why am I not seeing > > that change here.Am I missing something ? > > Something is wrong. You should see: > > commit fa52d96c3ea110acb77e51c856ec0b54606cc17e > Author: Giedrius Statkevičius <giedrius.statkevicius@xxxxxxxxx> > Date: Fri Apr 10 02:42:29 2015 +0300 > > staging: dgnc: clean up allocation of ->channels[i] > > > regards, > dan carpenter Yes Dan I was this commit and the comments.I updated my staging-testing tree regularly by doing a git pull.But I am not sure how this change went missing.Anyways this patch should be dropped. > > > > _______________________________________________ > > devel mailing list > > devel@xxxxxxxxxxxxxxxxxxxxxx > > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
