Re: [PATCH] staging: dgnc: check return value of kzalloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 29, 2015 at 07:44:11AM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
> check return value of kzalloc and return error if it fails.
> 

There is a problem with your patch.  See if you can spot it.  Also can
you add to the changelog what are the user visible effects of not
checking for kzalloc() failure?  Last time with ->flipbuf there were no
user visible effects.

Also return -ENOMEM seems like the wrong thing.  Shouldn't we do some
error handling.  Also you are not working on linux-next?  Some of this
stuff is done correctly in linux-next.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux