On Tue, May 19, 2015 at 01:32:22AM +0200, Pedro Marzo Perez wrote: > Merge two pr_debug lines with literal strings splitted across several lines > into one single line, simplifying prism2_wep_init error check code. I would have split this patch into three. 1) introduce pr_fmt and remove "ieee80211_crypt_wep" from pr_debug 2) return NULL instead of that goto fail. 3) combine two pr_debug into a single at the fail block. But Dan can say if its ok. (I am still taking ideas from Dan about my patches) regards sudip > > Signed-off-by: Pedro Marzo Perez <marzo.pedro@xxxxxxxxx> _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel