Re: [PATCH] staging: rtl8192e: replace printk with subsystem debug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 18, 2015 at 10:29:55PM +0200, Mateusz Kulikowski wrote:
> Hi,
> 
> On 18.05.2015 13:27, Gujulan Elango, Hari Prasath (H.) wrote:
> > replace the printk with netdev subsystem debug infrastructure.
> > 
> > Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx>
> > ---
> >  drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> > index fe3e7e12..f6e3f83 100644
> > --- a/drivers/staging/rtl8192e/rtllib_rx.c
> > +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> > @@ -344,7 +344,7 @@ rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee, struct sk_buff *skb,
> >  	res = crypt->ops->decrypt_msdu(skb, keyidx, hdrlen, crypt->priv);
> >  	atomic_dec(&crypt->refcnt);
> >  	if (res < 0) {
> > -		printk(KERN_DEBUG "%s: MSDU decryption/MIC verification failed (SA= %pM keyidx=%d)\n",
> > +		netdev_dbg(ieee->dev, "%s: MSDU decryption/MIC verification failed (SA= %pM keyidx=%d)\n",
> >  		       ieee->dev->name, hdr->addr2, keyidx);
> >  		return -1;
> >  	}
> > 
> I posted it already in one of my patches (v2, v3 - now I'm working on v4 with this change as well):
> https://lkml.org/lkml/2015/5/9/200 <- v3
> https://lkml.org/lkml/2015/4/13 <- v2
> 
> Regards,
> Mateusz

Ok i checked the git log to see if this change has already gone in.I
found a comment stating that printk with KERN_DEBUG shall be left as it
is.So i sent a patch for this.Ok lets drop this duplicate patch then :)

Regards,
Hari Prasath
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux