Actually, to be honest, I would prefer if you moved things without changing it too much. I have a script to review "move code to a new function" patches but if everything moves and changes as well then it's confusing and I have to do it by hand. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel