On 10.05.2015 09:49, Sudip Mukherjee wrote: > On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote: >> Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function. >> Code was not altered significantly, therefore in some places it generates >> LONG_LINE checkpatch.pl warnings. > apart from long line it is also giving warnings for: You're running checkpatch --strict right? > 1) multiple blank lines > 2) Blank lines aren't necessary before a close brace > 3) spaces preferred around that '+' I will fix them (as they're pretty straightforward), and will probably do --strict checks for my patches in future; I will not fix more complex checks in such cases, because patch like this was supposed to simplify function (i.e. split it) - without changing it's code too much. Is it ok with you? Regards, Mateusz _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
