I'm finished going through these patches. Pretty decent over all. My only comment was that there were three? places where we introduced a bug and then fixed it in a later patch. I kind of wish the fix were folded into the original patch. I don't know how awkward that is. If it's too difficult then don't worry about it. I also missed all three of those bugs so my review obviously wasn't perfect. :P regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
