On Tue, May 05, 2015 at 06:37:56PM -0400, Benjamin Romer wrote: > @@ -827,14 +818,6 @@ controlvm_respond(struct controlvm_message_header *msg_hdr, int response) > struct controlvm_message outmsg; > > controlvm_init_response(&outmsg, msg_hdr, response); > - /* For DiagPool channel DEVICE_CHANGESTATE, we need to send > - * back the deviceChangeState structure in the packet. */ > - if (msg_hdr->id == CONTROLVM_DEVICE_CHANGESTATE && > - g_devicechangestate_packet.device_change_state.bus_no == > - g_diagpool_bus_no && > - g_devicechangestate_packet.device_change_state.dev_no == > - g_diagpool_dev_no) > - outmsg.cmd = g_devicechangestate_packet; > if (outmsg.hdr.flags.test_message == 1) > return; > This is a puzzling chunk it doesn't seem to have anything to do with the commit message. The previous had an incomplete commit message as well. Anyway, g_devicechangestate_packet is a write only variable now so we can remove it? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
