Re: [PATCH] staging: comedi: coding style identation error fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 05/07/2015 08:21 AM, Sudip Mukherjee wrote:
On Thu, May 07, 2015 at 08:01:53AM -0500, Jaime Arrocha wrote:


On 05/07/2015 12:34 AM, Sudip Mukherjee wrote:
On Wed, May 06, 2015 at 05:13:41PM -0500, Jaime Arrocha wrote:
Errors found by checkpatch.pl.
ERROR: code indent should use tabs where possible
/drivers/staging/comedi/drivers/das16m1.c:49
/drivers/staging/comedi/drivers/das16m1.c:50

Signed-off-by: Jaime Arrocha <jarr@xxxxxxxxxxxxx>
---
you are sending this patch second time with different subject.
any reason for that?

regards
sudip


Yes, the first one had the subject line too long and not clear.
When I need to resend a patch like I did, should I add on the second
one the reason behind resending and dismissing the first one? Thank
you.

first of all you should reply to the first patch stating that should not
be applied and that you have sent a second patch. And this one should
have had a v2 in the subject with the reason of v2 below the --- cutoff.
since you have already sent the second patch just reply to the fist
patch as of now.
And you have sent the patches to greg@xxxxxxxxx, it should have been
gregkh@xxxxxxxxxxxxxxxxxxx . always use get_maintainer.pl to see whom
to send patches.

regards
sudip



Thanks Sudip, I will dismiss this one too and do it correctly. I accidentally took Greg's email from the TODO file.




This patch should not be applied.



Thanks,
jaime

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux