The image->depth != 1 case means the image is color. The current driver only does 2d in mono color image. I think we can let the driver fall back to cfb_imageblit() currently. Then we implement the color image 2d later. If we don't do anything for color image, the color image will not be displayed. Best Regards, Teddy Wang -----邮件原件----- 发件人: Sudip Mukherjee [mailto:sudipm.mukherjee@xxxxxxxxx] 发送时间: 2015年4月27日 17:00 收件人: Huacai Chen 抄送: Greg Kroah-Hartman; devel@xxxxxxxxxxxxxxxxxxxx; Binbin Zhou; Fuxin Zhang; Teddy Wang 王力强 主题: Re: [PATCH V2] staging: sm750: Fix lynxfb_ops_imageblit() if image->depth != 1 On Mon, Apr 27, 2015 at 04:10:53PM +0800, Huacai Chen wrote: > If image->depth != 1, lynxfb_ops_imageblit() should fallback to call > cfb_imageblit(), not return directly. Otherwise it can't display the > boot logo. I think it is wrong. lynxfb_ops_imageblit() is the imageblit callback if 2D acceleration is enabled. but cfb_imageblit() is the default imageblit function that the framebuffer layer is providing for drivers which do not have 2D acceleration. You will notice the default is mentioned as cfb_imageblit() when we were defining lynxfb_ops. So we should not fall back again to the default function even if 2D acceleration is on. Teddy: any comments about what should be the proper fix for this? regards sudip _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
