On Mon, Apr 27, 2015 at 04:10:53PM +0800, Huacai Chen wrote: > If image->depth != 1, lynxfb_ops_imageblit() should fallback to call > cfb_imageblit(), not return directly. Otherwise it can't display the > boot logo. I think it is wrong. lynxfb_ops_imageblit() is the imageblit callback if 2D acceleration is enabled. but cfb_imageblit() is the default imageblit function that the framebuffer layer is providing for drivers which do not have 2D acceleration. You will notice the default is mentioned as cfb_imageblit() when we were defining lynxfb_ops. So we should not fall back again to the default function even if 2D acceleration is on. Teddy: any comments about what should be the proper fix for this? regards sudip _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
