On Fri, Mar 27, 2015 at 09:47:16AM +0100, Greg Kroah-Hartman wrote: > On Fri, Mar 27, 2015 at 02:00:58PM +0530, Sudip Mukherjee wrote: > > } > > rc = cdev_add(&file_cdev, MKDEV(MAJOR(major_dev), 0), 1); > > if (rc < 0) { > > unregister_chrdev_region(major_dev, 1); > > - return -1; > > + return rc; > > I should have kept reading in the patch series, nice fix up :) some effect of learning from you and Dan :) thanks _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel