On Fri, Mar 27, 2015 at 02:00:57PM +0530, Sudip Mukherjee wrote:
> after registering the major numbers if the cdev_add fails then we were
> not releasing the major numbers. now we are doing that.
>
> Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> ---
> drivers/staging/unisys/visorchipset/file.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/visorchipset/file.c b/drivers/staging/unisys/visorchipset/file.c
> index 39b19af..074c285 100644
> --- a/drivers/staging/unisys/visorchipset/file.c
> +++ b/drivers/staging/unisys/visorchipset/file.c
> @@ -65,8 +65,10 @@ visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel)
> return -1;
> }
> rc = cdev_add(&file_cdev, MKDEV(MAJOR(major_dev), 0), 1);
> - if (rc < 0)
> + if (rc < 0) {
Care to delete the extra space while you are modifying this line?
> + unregister_chrdev_region(major_dev, 1);
> return -1;
It's not your fault, and don't change this, but something that needs to
be fixed up in the future are these "random" negative numbers being
returned. Use proper -ERROR #defines instead.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
