I don't like how these are broken up at all. It's random grab bag of renaming and deleting. Do it like this, perhaps: [patch 1] delete registered Leave the if (MAJOR(majordev) >= 0) for now, because it just confuses issues to mix it in. Delete all references to registered. [patch 1] use local variable in visorchipset_file_init() Don't delete anything. [patch 2] pass major_dev to visorchipset_file_cleanup() This deletes the "if (MAJOR(majordev) >= 0)" condition because it's obvious that can't be true. This deletes all references to the "majordev" global because that isn't needed any more. The whole reason it was needed originally was because of visorchipset_file_cleanup() so it's wrong to do the deleting in this patch which is about visorchipset_file_init(). regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
