On Tue, Mar 24, 2015 at 03:30:21PM +0300, Dan Carpenter wrote: > On Tue, Mar 24, 2015 at 05:47:34PM +0530, Sudip Mukherjee wrote: > > visorchipset_file_cleanup() is called from visorchipset_exit() which > > is the module_exit function and this function is executing means > > module_init succeeded, so registered will always be true at this time. > > and majordev has also been initialized in the init function. hence > > these comparisons will always be true. > > > > Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx> > > This is a partial patch. The "one thing per patch" means don't do half > a thing per patch. > > We now set "registered" but there are no users. it is being removed separately in the 4/4 patch. do you want that to be combined here in this patch? but then won't that become 2 different changes in a single patch? my message says we are removing that as the comparison is always true. regards sudip > > regards, > dan carpenter > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
