On Thu, Mar 19, 2015 at 08:13:20PM +0200, Giedrius Statkevičius wrote: > Hi Amitoj Kaur Chawla, > > On 2015.03.19 20:05, Amitoj Kaur Chawla wrote: > > The edits have been made to add a space before the comment and the errors in > > braces in the if-else statements. > > Previously in commit 2d34f53f1065878cd881ac61a183f8e836583d51, removed > > the C99 comments and errors in if-else indentation and braces. > > The previous patch isn't in the git repo yet so it doesn't have a commit > id thus this one is wrong. You should've just made a v2 and made that > change. I recommend you to look over this: > http://kernelnewbies.org/FirstKernelPatch Just remove the HEAD commit in > your local git repo, add that space and then when using `git > format-patch` use the "--subject-prefix" option to add that it's a > second version. Then after "---" you can say what was changed in the > second version. For example (I'm sure you can think of a better one!): > > Signed-off-by: ... > --- > v2: added a space after a statement in a line where a coding style error > was fixed. > > drivers/... Yes, please resend both of these. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
