On Wed, Mar 11, 2015 at 01:28:43AM +0000, Lorenzo Stoakes wrote: > > diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c > index 4aa763b..6521c3b 100644 > --- a/drivers/staging/sm750fb/sm750_accel.c > +++ b/drivers/staging/sm750fb/sm750_accel.c > @@ -92,7 +92,7 @@ void hw_set2dformat(struct lynx_accel * accel,int fmt) > /* seems sm712 RectFill command is broken,so need use BitBlt to > * replace it. */ > > -static int hw712_fillrect(struct lynx_accel * accel, > +int hw712_fillrect(struct lynx_accel * accel, > u32 base,u32 pitch,u32 Bpp, > u32 x,u32 y,u32 width,u32 height, > u32 color,u32 rop) in your previous patch 3/6 you made it static now you are again removing the static keyword. may i ask why you changed it in 3/6 if you again change it back to original in this patch? anyways, like Dan said, delete this function, its not used anywhere. it will not be used also, i missed removing this function from the vendor crude drver. regards sudip > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel