On Wed, Mar 11, 2015 at 01:28:42AM +0000, Lorenzo Stoakes wrote: > This patch declares externally unavailable functions static. This fixes the > following sparse warnings:- <snip> > diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c > index 6521c3b..4aa763b 100644 > --- a/drivers/staging/sm750fb/sm750_accel.c > +++ b/drivers/staging/sm750fb/sm750_accel.c > @@ -92,7 +92,7 @@ void hw_set2dformat(struct lynx_accel * accel,int fmt) > /* seems sm712 RectFill command is broken,so need use BitBlt to > * replace it. */ > > -int hw712_fillrect(struct lynx_accel * accel, > +static int hw712_fillrect(struct lynx_accel * accel, > u32 base,u32 pitch,u32 Bpp, > u32 x,u32 y,u32 width,u32 height, > u32 color,u32 rop) this is introducing a build warning, better remove this from your patch and send a separate patch to remove the function as this function is not used anywhere. regards sudip > -- > 2.3.2 > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel