On Tue, Mar 10, 2015 at 12:47:44PM +0000, Lorenzo Stoakes wrote: > On 10 March 2015 at 12:36, Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> wrote: > > but it is introducing two new build warnings: > > > > drivers/staging/sm750fb/sm750_hw.c: In function ‘hw_sm750_map’: > > drivers/staging/sm750fb/sm750_hw.c:67:2: warning: passing argument 1 of ‘ddk750_set_mmio’ discards ‘volatile’ qualifier from pointer target type [enabled by default] > > In file included from drivers/staging/sm750fb/ddk750_mode.h:4:0, > > from drivers/staging/sm750fb/ddk750.h:15, > > from drivers/staging/sm750fb/sm750_hw.c:24: > > > > and > > > > drivers/staging/sm750fb/ddk750_chip.h:77:6: note: expected ‘void *’ but argument is of type ‘volatile unsigned char *’ > > > > care to make another patch to solve these two new warnings, and send this patch and the new one in a series and while sending mark the version number in the subject. > > I think the second warning is simply additional information attached > to the 1st to give context? > > I noticed this issue but felt changing the type of this field would > sit outside the purview of this patch as then I'm not only changing > the type of mmio750 and code that *directly* interacts with this > variable, but also code that indirectly interacts with it, so I felt > that should perhaps be a separate patch. > > I'd love to additionally provide some further patches to help out with > issues here too, incidentally! I will try to prepare some further > patches tonight in this vein. I can't apply patches that add new build warnings, sorry. Please fix this up in the patch itself. greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
