On 10 March 2015 at 13:06, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > You should have said that in the patch description or under the --- > cut off. But anyway, it's not ok. And we'll need to redo this patch. > Breaking up patches into logical changes is sort of tricky because > everything touches everything else so the patch gets larger and larger. > Major apologies, I am still getting used to kernel development! I'll be careful to not make such assumptions in future when it comes to warnings/errors. [snip] > But maybe it's only one line larger than the patch you just send? In > that case just fold it in and don't do the temporary casting. > > The next patch after that could get rid of all the ramaining "volatile" > keywords. It seems that we can in fact fix this problem with a single additional change, I will submit a v2 shortly. Best, -- Lorenzo Stoakes https:/ljs.io _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
