Re: [PATCH] Staging: rtl8192u: r8190_rtl8256: coding style and format string type connections

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 08, 2015 at 08:46:28PM -0800, Tolga Ceylan wrote:
> Lines over 80 were corrected
> RT_TRACE format strings should specify unsigned instead of signed int

I don't understand, why did you do 2 different things in a single patch?

Please split this up.

Also:

>  		case RF90_PATH_C:
> -			u4RegValue = rtl8192_QueryBBReg(dev, pPhyReg->rfintfs, bRFSI_RFENV);
> +			u4RegValue = rtl8192_QueryBBReg(dev, pPhyReg->rfintfs,
> +				bRFSI_RFENV);

Please indent this to the character after '(' on the line above.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux