Re: [PATCH] staging: rtl8192u: r8192U_wx.h is now checkpatch-conform

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 16, 2015 at 11:22:37PM +0100, Patrick Boettcher wrote:
> This patch fixes warnings/errors raised by checkpatch.pl relating to
> line-length and comments in r8192I_wx.h.
> 
> Signed-off-by: Patrick Boettcher <patrick.boettcher@xxxxxxxxx>
> ---
>  drivers/staging/rtl8192u/r8192U_wx.h | 32 ++++++++++++++++++++------------
>  1 file changed, 20 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/r8192U_wx.h b/drivers/staging/rtl8192u/r8192U_wx.h
> index ae7a617..6665126 100644
> --- a/drivers/staging/rtl8192u/r8192U_wx.h
> +++ b/drivers/staging/rtl8192u/r8192U_wx.h
> @@ -1,23 +1,31 @@
>  /*
> -	This is part of rtl8180 OpenSource driver - v 0.3
> -	Copyright (C) Andrea Merello 2004  <andrea.merello@xxxxxxxxx>
> -	Released under the terms of GPL (General Public Licence)
> -
> -	Parts of this driver are based on the GPL part of the official realtek driver
> -	Parts of this driver are based on the rtl8180 driver skeleton from Patric Schenke & Andres Salomon
> -	Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver
> -
> -	We want to thank the Authors of such projects and the Ndiswrapper project Authors.
> -*/
> + *  This is part of rtl8180 OpenSource driver - v 0.3
> + *
> + *  Copyright (C) Andrea Merello 2004  <andrea.merello@xxxxxxxxx>
> + *
> + *  Released under the terms of GPL (General Public Licence)
> + *
> + *  Parts of this driver are based on the GPL part of the official
> + *    realtek driver
> + *  Parts of this driver are based on the rtl8180 driver skeleton from
> + *    Patric Schenke & Andres Salomon
> + *  Parts of this driver are based on the Intel Pro Wireless 2100 GPL
> + *    driver
> + *
> + *  We want to thank the authors of these projects and the
> + *    Ndiswrapper project authors.
> + *
> + */
>  
>  /* this file (will) contains wireless extension handlers*/
>  
>  #ifndef R8180_WX_H
>  #define R8180_WX_H
> -//#include <linux/wireless.h>
> +
> +/* #include <linux/wireless.h> */

Just remove the line please.

And the subject: should be more descriptive as to what you are doing,
not the end result.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux