2015-02-06 15:32 GMT+01:00 Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>: > On Thu, Feb 05, 2015 at 06:39:13PM +0100, Rickard Strandqvist wrote: >> 2015-02-05 13:51 GMT+01:00 Dan Carpenter <dan.carpenter@xxxxxxxxxx>: >> > On Thu, Feb 05, 2015 at 06:13:22PM +0530, Sudip Mukherjee wrote: >> >> if (driver_info) { >> >> stats->RxIs40MHzPacket = driver_info->BW; >> >> if (stats->RxDrvInfoSize != 0) >> >> TranslateRxSignalStuff819xUsb(skb, stats, driver_info); >> >> } >> > >> > If driver_info is non-NULL then stats->RxDrvInfoSize is not zero and >> > also the reverse. So really you only need to test one. >> > >> > regards, >> > dan carpenter >> > >> >> True Dan >> >> Okay, I'll make one last patch then, or if you want to do it Sudip? >> Have you not done before Saturday I do it. > no, its yours. you found it so credit should be yours. > I am sure Greg will accept this one. If he drops then maybe I can re-send with you as Reported-by > > regards > Sudip > >> >> Kind regards >> Rickard Strandqvist Thanks Sudip :) And after checking some more, I agree with Dan cleaner to only use if(driver_info) New patch coming soon. Kind regards Rickard Strandqvist _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel