On Thu, Feb 05, 2015 at 03:27:45PM +0300, Dan Carpenter wrote:
> I don't know if this patch was merged before Greg cleaned out his inbox.
>
> It's a good patch if you could just clean it up a bit.
>
> On Thu, Jan 29, 2015 at 07:59:12PM +0100, Rickard Strandqvist wrote:
> > Fix a possible null pointer dereference, there is
> > otherwise a risk of a possible null pointer dereference.
>
> The change log should say that "driver_info" is the NULL pointer. It
> should say that by default stats->RxIs40MHzPacket is zero (as opposed to
> uninitialized memory).
>
> >
<snip>
> > +++ b/drivers/staging/rtl8192u/r8192U_core.c
> > @@ -4476,11 +4476,11 @@ static void query_rxdesc_status(struct sk_buff *skb,
> >
> > /* for debug 2008.5.29 */
> >
> > - //added by vivi, for MP, 20080108
> > - stats->RxIs40MHzPacket = driver_info->BW;
> > - if (stats->RxDrvInfoSize != 0)
> > + if (driver_info && stats->RxDrvInfoSize != 0) {
> > + //added by vivi, for MP, 20080108
>
> Delete these kinds of comments, please.
>
>
> > + stats->RxIs40MHzPacket = driver_info->BW;
> > TranslateRxSignalStuff819xUsb(skb, stats, driver_info);
> > -
> > + }
but in the present form the logic is changing. can you please check the following idea -
if (driver_info) {
stats->RxIs40MHzPacket = driver_info->BW;
if (stats->RxDrvInfoSize != 0)
TranslateRxSignalStuff819xUsb(skb, stats, driver_info);
}
regards
sudip
>
> regards,
> dan carpenter
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
