Re: [PATCH 00/25] line6usb cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Mon, 12 Jan 2015 11:52:27 -0800,
Greg Kroah-Hartman wrote:
> 
> On Mon, Jan 12, 2015 at 05:35:01PM +0100, Takashi Iwai wrote:
> > At Sun, 11 Jan 2015 15:04:55 -0600,
> > Chris Rorvick wrote:
> > > 
> > > > At Fri,  9 Jan 2015 23:35:46 -0600,
> > > > Chris Rorvick wrote:
> > > >>
> > > >> I have a TonePort UX2 that I've used for testing, meaning that some of
> > > >> this is really only compile-tested.
> > > >
> > > > If anyone is responsible for testing with real hardware, I'll happily
> > > > review.
> > > 
> > > To be clear, the TonePort UX2 is real hardware.  But this driver
> > > basically supports four classes of Line 6 devices and I'm only covering
> > > one of them.
> > > 
> > > So this series is a first step in trying to address this.  Having this
> > > as a single driver probably made sense when it was a separate project,
> > > but now that it is in-tree it seems like the POD, PODHD, TonePort, and
> > > Variax pieces should each be separate drivers that each depend on a core
> > > Line 6 driver.  I think the cleanup in this series will make that
> > > easier.  None of this is my area of expertise, though, so advice and
> > > feedback is very welcome.
> > > 
> > > > are there any active developers for this driver?
> > > 
> > > I intended to do further work.  I know there is quite a bit of mundane
> > > checkpatch cleanup that would need to get done before this could get
> > > promoted, and I believe I read that it's using sysfs for stuff that
> > > would normally be done via an ALSA interface, and the sysfs interface
> > > has not been documented nor has it been justified.  All stuff I thought
> > > I might look into.
> > > 
> > > But I'm just doing this for fun so I can't promise anything.  :-)
> > 
> > OK, so the situation looks fairly good, we have a few active
> > developers and/or testers.  And the current code doesn't look so
> > terrible despite of it being in staging directory.  That said, I think
> > we can promote this stuff into sound/usb/line6 directory, then apply
> > Chris' cleanup patches, and work on it further.
> > 
> > Does it sound OK for you guys?  Greg?
> > 
> > Once when I get approval, I'll start a new clean branch on sound.git
> > tree so that you guys can work on it further for 3.20 kernel.
> 
> That sounds fine with me.  I have 4 other patches in my "to-apply" queue
> other than these 25 for this driver that I'll forward on to you for
> inclusion in your tree.

OK, feel free to mail me.


Thanks!

Takashi
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux