Re: [PATCH v8 0/4] FPGA Manager Framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/11, Pavel Machek wrote:
> On Sun 2015-01-11 17:24:26, Konrad Zapalowicz wrote:
> > On 01/11, atull wrote:
> > > On Sat, 10 Jan 2015, Konrad Zapalowicz wrote:
> > > 
> > > > On 01/06, atull@xxxxxxxxxxxxxxxxxxxxx wrote:
> > > > > From: Alan Tull <atull@xxxxxxxxxxxxxxxxxxxxx>
> > > > 
> > > > Alan, there is something wrong with your email client configuration
> > > > and you need to fix.
> > > > 
> > > > thanks,
> > > > konrad
> > > 
> > > Hi Konrad,
> > > 
> > > Can you be more specific?  What problem are you seeing?  Is it a problem 
> > > with the original patch  post or when I reply?  When I a post, I'm using
> > > 'git send-email' with sendmail and when I am replying, I am using alpine.
> > 
> > I think that because you email client configuration sets the 'From'
> > header to "atull@..." and at the same time you sign-off messages with
> > "Alan Tull atull@..." the "From" is added at the beginning of the
> > message to indicate the original author.
> > 
> > This should be fixed as the "from" is not welcomed in the body of the
> > commit message.
> 
> Actually, why not? Tools should know to look at From: in the
> commit. AFAICT, Alan has it set up correctly.

I think he has not. I suspect that the sendmail configuration in the git
config might be wrong. The 'from' must contain the same data as the git
is configured for the user.name and user.email options. Otherwise the
send-email is adding the "From: ..." to the message body.

cheers,
konrad

>								Pavel
> 								
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux