On Fri, Dec 05, 2014 at 05:09:26PM -0500, Benjamin Romer wrote:
> Remove the ERRDRV() macro family and use pr_err directly everywhere it was used.
> Completely remove any error messages that used the macro but are redundant, for
> example, several of the messages were from memory allocation failures.
That's a lot of different things to be doing all in one patch.
I'm happy to see you get rid of some of your macros, but you can't just
replace them with pr_err, lots of these should be dev_err() instead.
Try doing just one thing at a time here please.
I've taken the patches up to this one.
Also:
> - LOGERR("CONTROLVM_BUS_CREATE Failed: max buses:%d already created\n",
> + pr_err("CONTROLVM_BUS_CREATE Failed: max buses:%d already created\n",
What is with all of the "CONTROLVM_BUS_CREATE" type strings in messages?
That's not really needed, right?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
