Krzysztof Konopko <kris@xxxxxxxxxxx> writes: > On 12/12/14 00:53, Larry Finger wrote: >> In RTL8188EU, both BA_starting_seqctrl and TXOP_limit are unsigned short. >> > > That's not quite the case. `TXOP_limit` is __le16 in RTL8188EU [1]. > It's __le16 even in your GitHub repo [2]. And that made me thinking > that there's probably some inconsistency in the header. > > I'm _far_ from being a wireless expert but doesn't data coming out of > the wire/air have the endianess defined explicitly? And both `AC_param` > and `ADDBA_request` come out of air? > > I was hunting particularly for inconsistencies with `sparse` and came > across this one. But I dug a bit further and I wonder why the driver is > not using standard stuff like the one in `include/linux/ieee80211.h` > where any data wider than one byte is clearly declared as __le<nn>? In general all over the wire data is little-endian. The driver has been slowly moved towards using the standard defines from the Linux headers, but this is a *lot* of work, and it requires testing. I really don't get warm fuzzy feelings from patches that blindly make these kinds of changes without also testing them. Jes _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
