Re: [PATCH socfpga-nex] staging: fpga manager: socfpga_fpga_ops can be static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 11 Dec 2014, One Thousand Gnomes wrote:

> On Thu, 11 Dec 2014 09:43:24 +0800
> kbuild test robot <fengguang.wu@xxxxxxxxx> wrote:
> 
> > drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static?
> > 
> > Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> 
> Ought to be const as well by the look of it - we don't want function
> pointers in patchable memory spaces.
> 

I agree.  Will be in v5.

Alan
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux