Re: [PATCH v2] Staging: dgnc: Fix long line coding style issues in dgnc_cls.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/03/2014 06:37 PM, Joe Perches wrote:
On Wed, 2014-12-03 at 21:30 +0000, Sean Cleator wrote:
A patch to fix the rest of the long line warnings in the dgnc_cls.h file
found by the checkpatch.pl tool

checkpatch is a brainless little tool.

You should prefer to develop a readable style rather than
pay too close attention to precisely what checkpatch says.

fyi: There is this warning in the file:

  *	NOTE: THIS IS A SHARED HEADER. DO NOT CHANGE CODING STYLE!!!


That comment should be removed. It was put there when this driver was under Digi's CVS control. Some of their user land apps, delivered with the driver package, also used it. They probably had different people working on the kernel and user land side.

Mark
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux