On Wed, Dec 03, 2014 at 09:34:41AM -0800, Greg KH wrote: > > +#define UART_IIR_CTSRTS 0x20 /* > > + * Received CTS/RTS change of > > + * state > > + */ > > That's pretty ugly, don't you think? How about putting the comments on > the line before the #define, instead of at the end? That would make > things much nicer to read. > I was going to say the same thing but it looks worse in the mail client because of how the tabs work out. In the code it doesn't look terrible. #define UART_IIR_CTSRTS 0x20 /* * Received CTS/RTS change of * state */ Another idea would be to just remove a tab. It wouldn't align with the section before but it would align with the next section down. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel