On Tuesday, October 21, 2014 8:14 AM, Ian Abbott wrote: > On 20/10/14 18:37, H Hartley Sweeten wrote: >> According to ADDI-DATA, this board was discontinued last year and they >> feel that no further development is needed for this driver. Remove the >> driver from comedi to help with the addi-data cleanup. >> >> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> >> Cc: Ian Abbott <abbotti@xxxxxxxxx> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> --- >> drivers/staging/comedi/Kconfig | 8 - >> drivers/staging/comedi/drivers/Makefile | 1 - >> .../comedi/drivers/addi-data/hwdrv_apci035.c | 482 --------------------- >> drivers/staging/comedi/drivers/addi_apci_035.c | 129 ------ >> 4 files changed, 620 deletions(-) >> delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c >> delete mode 100644 drivers/staging/comedi/drivers/addi_apci_035.c > > An alternative may be to convert it into a very simple driver by > stripping out all the interrupt, timer and watchdog stuff, and just > leave an AI subdevice just with insn_read support. But even that seems > hopelessly broken in this driver - it doesn't seem to bother selecting > the channel or the range, for example. So I've no qualms about removing > it altogether. I don't think this board really "fits" with comedi. It's not actually a data acquisition board. The 4 watchdog timers on the board are used to trigger the 2 relays to indicate alarm conditions. In addition the 1 digital input can trigger the relays or they can be triggered through software. The 1 analog input is connected to a temperature sensor on the board. Looks like it would fit better in the iio subsystem to me. Regardless, ADDI-DATA has discontinued the board. Since the current state of the driver is unusable without external patches from ADDI-DATA that disable the insn checking I think it's better to just drop this driver. Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx> Regards, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
