Re: [PATCH] staging: comedi: addi_apci_035: remove driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20/10/14 18:37, H Hartley Sweeten wrote:
According to ADDI-DATA, this board was discontinued last year and they
feel that no further development is needed for this driver. Remove the
driver from comedi to help with the addi-data cleanup.

Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
Cc: Ian Abbott <abbotti@xxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
  drivers/staging/comedi/Kconfig                     |   8 -
  drivers/staging/comedi/drivers/Makefile            |   1 -
  .../comedi/drivers/addi-data/hwdrv_apci035.c       | 482 ---------------------
  drivers/staging/comedi/drivers/addi_apci_035.c     | 129 ------
  4 files changed, 620 deletions(-)
  delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c
  delete mode 100644 drivers/staging/comedi/drivers/addi_apci_035.c

An alternative may be to convert it into a very simple driver by stripping out all the interrupt, timer and watchdog stuff, and just leave an AI subdevice just with insn_read support. But even that seems hopelessly broken in this driver - it doesn't seem to bother selecting the channel or the range, for example. So I've no qualms about removing it altogether.

Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux