On Wed, Oct 15, 2014 at 01:26:07PM -0700, Jeff Kirsher wrote: > On Wed, 2014-10-15 at 22:55 +0300, Dan Carpenter wrote: > > On Wed, Oct 15, 2014 at 12:01:41PM -0700, Jeff Kirsher wrote: > > > From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > > > > > > The Beceem WIMAX was generating compile warnings on 64bit machines, > > > which were: > > > > > > drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’: > > > drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > > > (struct bcm_connect_mgr_params *) ntohl( > > > ^ > > > drivers/staging/bcm/CmHost.c:1546:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > > > (struct bcm_connect_mgr_params *) ntohl( > > > ^ > > > drivers/staging/bcm/CmHost.c:1564:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > > > (struct bcm_connect_mgr_params *) ntohl( > > > > > > This resolves the issue by preventing the driver to compile if CONFIG_64BIT > > > is enabled, since the driver is known to be broken for 64 bit arch's. > > > > > > > Oops. Someone turned a Joe patch into a real patch. Please enable > > COMPILE_TEST for this. > > I agree with Joe, that COMPILE_TEST is not useful for this driver. If we remove the driver fine, but if we keep the driver then we should do enable any QA testing we can. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
