On Thu, Sep 04, 2014 at 05:47:53PM +0300, Eli Billauer wrote:
> Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Eli Billauer <eli.billauer@xxxxxxxxx>
> ---
> drivers/staging/xillybus/xillybus_core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/xillybus/xillybus_core.c b/drivers/staging/xillybus/xillybus_core.c
> index 04c60c6..5ed89ce 100644
> --- a/drivers/staging/xillybus/xillybus_core.c
> +++ b/drivers/staging/xillybus/xillybus_core.c
> @@ -664,7 +664,7 @@ static int xilly_obtain_idt(struct xilly_endpoint *endpoint)
> if (*version > 0x82) {
> dev_err(endpoint->dev,
> "No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgarde. Aborting.\n",
> - (int) *version);
> + (unsigned int) *version);
Let's drop this one.
Sorry, I was just wrong on here. I misread the code and also my
review comments were too vague and must have puzzled you. (Feel free
to call me out on this if I'm wrong next time.)
Looking at it now, before and after of this are basically the same.
Really, I don't think there is any casting needed.
It won't affect any of the other patches in the series so no need to
resend anything.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
