These patches are a result of Dan Carpenter's remarks after looking at the driver. A huge thanks goes to him for taking the time to review the code, and his clear and helpful comments. A significant part of the corrections is my extrapolation of Dan's remarks on similar cases. If something silly stands out in these patches, odds are it's me, not Dan. :) Regards, Eli Eli Billauer (18): staging: xillybus: Use devm_kcalloc() for arrays staging: xillybus: Use SEEK_* predefined constants staging: xillybus: Non-interruptible mutex_lock() on release method staging: xillybus: Removed unnecessary warning message staging: xillybus: Removed unnecessary error message staging: xillybus: Improved error handling staging: xillybus: Improved goto flow for error handling staging: xillybus: EAGAIN status handling improvement staging: xillybus: Fixes related to "rc" variable staging: xillybus: Use the return value of wait_event_interruptible staging: xillybus: Clarified the stop condition for a loop staging: xillybus: Added curly brackets as required staging: xillybus: Fix comments staging: xillybus: Fix incorrect cast staging: xillybus: Reorganize line breaks for clarity staging: xillybus: Trivial coding style fixes staging: xillybus: Fix indentations staging: xillybus: Blank lines add/remove drivers/staging/xillybus/xillybus.h | 1 - drivers/staging/xillybus/xillybus_core.c | 325 ++++++++++++------------------ drivers/staging/xillybus/xillybus_of.c | 5 +- drivers/staging/xillybus/xillybus_pcie.c | 16 +- 4 files changed, 144 insertions(+), 203 deletions(-) -- 1.7.2.3 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
